Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Error in count condition of HTTP-Api-Gateway #60

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix: Error in count condition of HTTP-Api-Gateway #60

wants to merge 8 commits into from

Conversation

Aatishsharma77
Copy link
Contributor

@Aatishsharma77 Aatishsharma77 commented Apr 5, 2024 •
edited by h1manshu98
Loading

what

Fixed count condition for module "kms_key" {}, data "aws_iam_policy_document" "cloudwatch" {} in main.tf
This was causing below error on terraform plan

│ Error: Invalid index
│ 
│   on ../../../main.tf line 543, in module "kms_key":
│  543:   policy              = data.aws_iam_policy_document.cloudwatch[0].json
│     ├────────────────
│     │ data.aws_iam_policy_document.cloudwatch is empty tuple
│ 
│ The given key does not identify an element in this collection value: the collection has no elements.

@clouddrove-ci clouddrove-ci self-assigned this Apr 5, 2024
@Aatishsharma77 Aatishsharma77 added the bug Something isn't working label Apr 5, 2024
@Aatishsharma77 Aatishsharma77 changed the title Fix: Enable of kms_key in HTTP Api-Gateway Fix: Error in count condition of HTTP-Api-Gateway Apr 8, 2024
h1manshu98
h1manshu98 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h1manshu98 h1manshu98 h1manshu98 approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@themaniskshah themaniskshah Awaiting requested review from themaniskshah

@13archit 13archit Awaiting requested review from 13archit

@vaibhav7797 vaibhav7797 Awaiting requested review from vaibhav7797

@VishwajitNagulkar VishwajitNagulkar Awaiting requested review from VishwajitNagulkar

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@Aatishsharma77 Aatishsharma77

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aatishsharma77 @h1manshu98 @clouddrove-ci